Manually link page next-prev across child borders #1985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous and next navigation links at the bottom of the page get filled automatically by vuepress, sourced from the (locale-specific) sidebar configuration. We define the sidebar through sections - which may be single page sections or a section with child pages. Previously, the website did not guide the user through our book. * Section prev always linked to previous section, never previous sections last child if available * Section next never linked to first child of section, if available * First child did not offer a prev link * Last child did not offer a next link I did not see documentation about customizing the auto-discover behavior, nor the sidebar structure dependency of the automatic determination. But page frontmatter can override the prev and next links. As a fixup, overriding the automatic discovery from the sidebar, we manually set the prev and next links on section child borders. The link text matches the headline/sidebar, and the links the sidebar structure. Given that this is manual configuration, there's a risk of it eventually being missed and becoming outdated or wrong when structure changes are made. I did not test. I don't have a local nodejs env. Resolves nushell#1818 * https://v1.vuepress.vuejs.org/theme/default-theme-config.html#prev-next-links * https://v1.vuepress.vuejs.org/guide/i18n.html#default-theme-i18n-config * https://ecosystem.vuejs.press/themes/default/frontmatter.html#prev
|
Could you please update |
|
@hustcer Book looks fine to me with generated link though because it has no children!? https://www.nushell.sh/book/ has a Next link to Installation. I see that install has a default shell sub page. Seems like I missed that? I will take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous and next navigation links at the bottom of the page get filled automatically by vuepress, sourced from the (locale-specific) sidebar configuration.
We define the sidebar through sections - which may be single page sections or a section with child pages.
Previously, the website did not guide the user through our book.
I did not see documentation about customizing the auto-discover behavior, nor the sidebar structure dependency of the automatic determination. But page frontmatter can override the prev and next links.
As a fixup, overriding the automatic discovery from the sidebar, we manually set the prev and next links on section child borders. The link text matches the headline/sidebar, and the links the sidebar structure. Given that this is manual configuration, there's a risk of it eventually being missed and becoming outdated or wrong when structure changes are made.
I did not test. I don't have a local nodejs env.
Resolves #1818